Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repulsion effect): Add example of Repulsion Effect #107

Merged
merged 5 commits into from
Feb 28, 2024
Merged

feat(repulsion effect): Add example of Repulsion Effect #107

merged 5 commits into from
Feb 28, 2024

Conversation

damienmontastier
Copy link
Contributor

@damienmontastier damienmontastier commented Feb 26, 2024 •
edited
Loading

This is a example inspired by the tutorial of repulsion effect from Codrops adapted for Tresjs

@netlify Netlify
Copy link

netlify bot commented Feb 26, 2024 •
edited
Loading

✅ Deploy Preview for tresjs-labs ready!

Name Link
🔨 Latest commit b8c3103
🔍 Latest deploy log https://app.netlify.com/sites/tresjs-labs/deploys/65df1079d89db300086f0285
😎 Deploy Preview https://deploy-preview-107--tresjs-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@damienmontastier damienmontastier changed the title new lab example repulsion effect feat(repulsion effect): Add example of Repulsion Effect Feb 26, 2024
JaimeTorrealba
JaimeTorrealba reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi my friend this look awesome, I drop some questions and suggestions

The cone and the cylinder are rotating way too fast in comparison with the original demo, could you check that little detail?

Also, please remove the package-lock from the PR

components/content/repulsion-effect/index.vue Outdated Show resolved Hide resolved
components/content/repulsion-effect/index.vue Outdated Show resolved Hide resolved
@damienmontastier
Copy link
Contributor Author

Hey @JaimeTorrealba , I've updated everything 😉

JaimeTorrealba
JaimeTorrealba approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@JaimeTorrealba JaimeTorrealba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look everything fine. Thanks for the adjustments

PD: Remember that you shouldn't mark conversations as resolve (only the reviewer) :D

@damienmontastier
Copy link
Contributor Author

@JaimeTorrealba My bad, thanks for the advice 😊

@JaimeTorrealba JaimeTorrealba merged commit 86cc1c9 into Tresjs:main Feb 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaimeTorrealba JaimeTorrealba JaimeTorrealba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damienmontastier @JaimeTorrealba