Skip to content

[DOCS] Box colour change -- TiddlyWiki Privacy and Security#8769

Closed
pmario wants to merge 1 commit intoTiddlyWiki:tiddlywiki-comfrom
pmario:docs-box-colour-change-tiddlywiki-privacy-and-security-20241121173608268
Closed

[DOCS] Box colour change -- TiddlyWiki Privacy and Security#8769
pmario wants to merge 1 commit intoTiddlyWiki:tiddlywiki-comfrom
pmario:docs-box-colour-change-tiddlywiki-privacy-and-security-20241121173608268

Conversation

@pmario
Copy link
Member

@pmario pmario commented Nov 21, 2024

This PR changes the box-colors for "Single file Wiki" and "Node.js Wiki" box.
It uses diff-insert-* and diff-delete-* colour definitions

.tc-grid-columns.tc-grid-columns-2 > div {
	border-radius: 1em;
	padding: 1em;
	color: <<colour diff-insert-foreground>>;
	background-color: <<colour diff-insert-background>>;
}

.tc-grid-columns.tc-grid-columns-2 > div:nth-child(even) {
	color: <<colour diff-delete-foreground>>;
	background-color: <<colour diff-delete-background>>;
}

Submitted using https://saqimtiaz.github.io/tw5-docs-pr-maker/.

@github-actions
Copy link

github-actions bot commented Nov 21, 2024

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 0af68f0
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/673f618165c7c000088cd05e
😎 Deploy Preview https://deploy-preview-8769--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pmario
Copy link
Member Author

pmario commented Nov 21, 2024

image

@Jermolene
Copy link
Member

Jermolene commented Nov 25, 2024

Hi @pmario the current colours aren't perfect, but I did actually want to avoid pairing red with green like that because there might be an implied semantics that would be confusing. The two palette colours we're using at present give us consistent results and are reasonably harmonious.

@pmario pmario closed this Nov 26, 2024
@pmario pmario deleted the docs-box-colour-change-tiddlywiki-privacy-and-security-20241121173608268 branch May 24, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pmario @Jermolene