Migrate some old macros to new syntax#8768
Conversation
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| \procedure colour-picker-recent-inner(actions) | ||
| \whitespace trim | ||
| <$set name="colour-picker-value" value="$(recentColour)$"> | ||
| <$macrocall $name="colour-picker-inner" actions=<<__actions__>>/> |
There was a problem hiding this comment.
@Jermolene -- Do we really need to convert <$macrocall to a <$transclude $variable -- I personally like the macrocall much more, since it is a 100 times more verbose and human readable than the transclusion?
There was a problem hiding this comment.
For me the reason is that macrocall widget is marked deprecated since v5.3.0.
There was a problem hiding this comment.
I also support $transclude. This makes learning easier.
Also procedures replace macros, so $macrocall for procedures is a bit confusing. All in all $transclude is my favorite to go.
There was a problem hiding this comment.
Yes I think we have decided to deprecate the <$macrocall> widget. I am not against trying evolving the shortcut syntax. It would be very nice to be able to just do something like <<colour-picker-inner actions=<<actions>>>>.
|
@Leilei332 -- It's a bit problematic, that there are so many different macros in 1 PR. -- If one of them causes a problem in the future, the whole PR will be reverted. So I think it makes more sense to split this PR into several smaller ones. I have had that problem several times already. It is very frustrating if 8 files get reverted, but only one of them causes a problem. For procedures |
|
I think only the |
That's not really true. The tabs macro interferes with this PR: #8108 -- It's not directly related, but the tabs-macro is of interest. So it should definitely be in it's own PR. -- I am not really interested in the other macros atm. |
|
Thanks @Leilei332 |
This reverts commit 2801eee.
4 participants
Migrate some old macros like
colour-picker,translinkto use new syntax.The colour-picker macro has been updated to solve the problem mentioned in #8606 (comment).