Add dir attribute to simple inputs and framed inputs#8697
Closed
BurningTreeC wants to merge 2 commits intoTiddlyWiki:masterfrom
Closed
Add dir attribute to simple inputs and framed inputs#8697BurningTreeC wants to merge 2 commits intoTiddlyWiki:masterfrom
BurningTreeC wants to merge 2 commits intoTiddlyWiki:masterfrom
Conversation
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
Contributor
|
Actually there exists a pending PR for bidrectional text direction improvements: |
Contributor
Author
|
I will close this PR in favor of more advanced improvements like #7557 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the simple and framed inputs inherit the
dirattribute from thehtmlelementWhile the simple inputs should already inherit the direction from the context, the framed engine does not