Fix: disable the storyview scroll in the "Open" tab#8696
Fix: disable the storyview scroll in the "Open" tab#8696BurningTreeC wants to merge 7 commits intoTiddlyWiki:masterfrom
Conversation
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
|
to reproduce:
to compare, here's a build with this PR: |
|
This fixes also the behavior of |
|
@Jermolene - can we consider this? |
|
@BurningTreeC I am struggling to understand the purpose of this PR despite having read the top post twice. Can you please provide a description of the problem that this is meant to fix? |
I've updated the description |
|
@Jermolene - could we consider this PR? |
|
Hi @BurningTreeC it's too late for inclusion in v5.3.6, I'm afraid. I would like to fix the problem that the PR tackles – the symptom that I have run into in the past has been that the animation of the "open" tab interrupts that of the story river. The impact of this PR is quite broad so I would like to give it more consideration for the next release. |
|
This fix is applied more semantically correct in #9228 |
|
This PR adds a variable
tv-disable-storyview-scrollthat, if set, disables the scrolling to the target element.This is useful in the sidebar's "Open" tab for example, where under certain circumstances it can cause the sidebar to scroll when opening a new tiddler or the control panel
Opening a tiddler in the story-river makes the storyview navigate to that tiddler.
At the same time there's a storyview in the "Open" tab and also there a navigation occurs but it should not.
This PR fixes this issue