Skip to content

Improve package json new scripts#8695

Draft
pmario wants to merge 14 commits intoTiddlyWiki:masterfrom
pmario:improve-package-json-new-scripts
Draft

Improve package json new scripts#8695
pmario wants to merge 14 commits intoTiddlyWiki:masterfrom
pmario:improve-package-json-new-scripts

Conversation

@pmario
Copy link
Member

@pmario pmario commented Oct 20, 2024

A second try to add some more developer commands to the package.json file.

The new commands should also give an overview to what's possible with TW command parameters.


@Jermolene -- if the "echo" command would be implemented into tiddlywiki.info, I can remove library:info and prelibrary from the scripts section in this PR:

Jeremy's comment: #8689 (comment)

Yes I am happy to cherry pick the echo command, and possibly the terminal colour improvements.

@github-actions
Copy link

Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member Author

pmario commented Oct 29, 2024

@Jermolene -- I think the TW GitHub build process needs to be adjusted to use Node.js LTS 22.x.y

The minimum requirement for the --watch-path is Node v20.13.0 where this parameter was marked stable.

I did test the parameter with an earlier Node version and it did cause problems with Windows. Where it did run into an endless loop.

Node LTS 20.x.y is now in maintenence mode. See: https://nodejs.org/en/about/previous-releases

So we should use Node.js version 22 which will be the next LTS version for our GH build system

It seems we use Node version 18 for our build system, which will be End of Live in April 25

@pmario pmario marked this pull request as ready for review November 1, 2024 16:07
@netlify
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 2253889
🔍 Latest deploy log https://app.netlify.com/projects/tiddlywiki-previews/deploys/6846fe6bbef59d0008eaa48c
😎 Deploy Preview https://deploy-preview-8695--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Jermolene
Copy link
Member

Thanks @pmario, I am in favour of improving package.json wherever we can. I would like to seek a little more feedback on these changes so that we can serve the needs of as wide a set of users as possible.

@pmario pmario marked this pull request as draft February 18, 2025 14:48
@pmario
Copy link
Member Author

pmario commented Feb 18, 2025

As I wrote at the #8689 Dynamic Build Commands. I'll do some more testing.

May be I can go back to the advanced version with dynamic commands.

Will give feedback

@Leilei332 Leilei332 mentioned this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants