Conversation
|
Confirmed: BurningTreeC has already signed the Contributor License Agreement (see contributing.md) |
|
This now works and deferres the changes for both styleRefresh and mainRefresh in both the main window and new windows |
|
@Jermolene @pmario @saqimtiaz here's a build with performance instrumentation enabled: |
Seems to be slightly faster than the tiddlywiki/prerelease |
This comment has been minimized.
This comment has been minimized.
Hello @Leilei332 - do you notice this in general or in this PR? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Thanks @BurningTreeC this is promising, but I don't think we're ready to include it in v5.3.6. One issue is that the code of render.js is now pretty gnarly and hard to follow. I think we need to consider refactoring the rendering and refreshing into a generic class that can be used both for styles and body content. In a separate branch I've been exploring the idea with a new "wikifier" class. See this commit. It will need to be extended to allow it to replace all the occurrences of rendering/refreshing in the system. |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2525.0 KB |
| PR | 2529.9 KB |
Diff: ⬆️ Increase: +5.0 KB
Hi @Jermolene , I believe I did just that |
| /*jslint node: true, browser: true */ | ||
| /*global $tw: false */ |
There was a problem hiding this comment.
These comments are also not needed now.
This PR reworks the throttled refresh so that it works for the styleRefresh, too.
It adds two switches so that we can control if we want only the styleRefresh to throttle or only the mainRefresh to throttle.
It also makes the styleRefresh in new Windows equal to the styleRefresh in the main window.
Also in new windows the throttling is added, the same way as in the main window.