Add DiffTextWidget colors to some palettes#8661
Conversation
|
|
|
Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md) |
|
If you have a look at the palette-manager edition: https://wikilabs.github.io/editions/palette-manager/ All of them should have DiffText colours assigned. Some feedback would be welcome. That's a reminder, that I should create a PR for all palettes. Since all of the core palettes have some missing elements. |
|
There are still a lot of palettes that doesn't have
While those palettes have their own diff colors, which I think can be included in the PR:
|
|
If they do not have the indexes in the palette, they use the default from vanilla. That is intended. But I will have a closer look. I have seen some problems with some dark palettes, where the text is invisible. |
Thank you for using a consistent method for adding new color values! Everywhere you have use 6 chars hex code! Keep going on! |
|
I think only changing the foreground-colour is not enough. We have to take "colour blindness" into account. Eg: this is "Nord dark WL" palette: Accessibility setting: Simulate: Protanopia (no red) This is the same setting, that I use with my Palette-Manager edition, with the same Accessibility setting The same screenshot for "normal vision" |
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @Leilei332 |





Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.
Before:
After: