Skip to content

Add DiffTextWidget colors to some palettes#8661

Merged
Jermolene merged 4 commits intoTiddlyWiki:masterfrom
Leilei332:palette-diff
Dec 5, 2024
Merged

Add DiffTextWidget colors to some palettes#8661
Jermolene merged 4 commits intoTiddlyWiki:masterfrom
Leilei332:palette-diff

Conversation

@Leilei332
Copy link
Contributor

@Leilei332 Leilei332 commented Oct 4, 2024

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Before:

图片

After:

图片

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link

github-actions bot commented Oct 4, 2024

Confirmed: Leilei332 has already signed the Contributor License Agreement (see contributing.md)

@pmario
Copy link
Member

pmario commented Oct 4, 2024

If you have a look at the palette-manager edition: https://wikilabs.github.io/editions/palette-manager/
There are a lot of palettes, that have a WL at the end of the name.

All of them should have DiffText colours assigned. Some feedback would be welcome.

That's a reminder, that I should create a PR for all palettes. Since all of the core palettes have some missing elements.

@Leilei332
Copy link
Contributor Author

There are still a lot of palettes that doesn't have diff-* indexes in the palette manager edition, like the two palettes:

  • Solarized Light/Dark WL
  • Solar Flare WL
  • Spartan Day/Night WL

While those palettes have their own diff colors, which I think can be included in the PR:

  • Nord WL
  • DesertSand WL
  • GruvboxDark WL
  • Twlight WL

@pmario
Copy link
Member

pmario commented Oct 4, 2024

If they do not have the indexes in the palette, they use the default from vanilla. That is intended. But I will have a closer look. I have seen some problems with some dark palettes, where the text is invisible.

@Leilei332 Leilei332 marked this pull request as ready for review October 7, 2024 00:06
@kookma
Copy link
Contributor

kookma commented Oct 7, 2024

Add DiffTextWidget colors to Solarized, Solar Flare, Nord, GruvboxDark, DesertSand and Twlight palette to make them display properly.

Thank you for using a consistent method for adding new color values! Everywhere you have use 6 chars hex code! Keep going on!

@pmario
Copy link
Member

pmario commented Oct 7, 2024

I think only changing the foreground-colour is not enough. We have to take "colour blindness" into account.

Eg: this is "Nord dark WL" palette: Accessibility setting: Simulate: Protanopia (no red)

image

This is the same setting, that I use with my Palette-Manager edition, with the same Accessibility setting

image

The same screenshot for "normal vision"

image

@netlify
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit dfef1b0
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67406e298b6ea20008a7a4d6
😎 Deploy Preview https://deploy-preview-8661--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Leilei332
Copy link
Contributor Author

I've updated the palette to improve contrast:

图片

图片

@Jermolene
Copy link
Member

Thanks @Leilei332

@Jermolene Jermolene merged commit dd70e37 into TiddlyWiki:master Dec 5, 2024
@Leilei332 Leilei332 deleted the palette-diff branch December 8, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants