Project Movies - Joyce Kuo #87
Conversation
There was a problem hiding this comment.
Well done! Overall, your project looks really great!
Separation of Concerns: The code is nicely modular, with individual components like BackLink, Header, MovieCard, and MovieDetails, each handling a distinct part of the functionality or UI. This makes the code easier to maintain and debug. Nice!
Styled Components: Great use of styled-components for CSS-in-JS. This helps in keeping styles closely tied to the components, and makes the codebase more maintainable. Great!
Responsive Design: There are media queries used for responsiveness, which is great to ensure that the site works across a wide range of devices.
I left very few comments in the code. Keep it up :)
|
|
||
| {/* Explicitly handles invalid movie IDs */} | ||
| <Route path="/not-found" element={<ErrorPage />} /> | ||
| </> |
There was a problem hiding this comment.
I like that you added two different error pages to inform the user better about the problem!
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| bottom: 0; |
There was a problem hiding this comment.
for top: 0, left: 0... you could take the short version: inset: 0;
| name="description" | ||
| content="Browse popular, top-rated, now playing, and upcoming films with ratings and description available." | ||
| /> | ||
| <title>Showtime Selector</title> |
There was a problem hiding this comment.
here are two <title> tags. I think, it should only be one
https://showtime-selector.netlify.app/