Annas moviezone #86
Annas moviezone #86
Conversation
…ow playing and upcoming movies in Sweden
…nd imported to app.jsx, added a background image for all pages
…ore styling in other components
…a queries, created a back button with an arrow img
…ing for about page
There was a problem hiding this comment.
Great job with this project Anna! I really like how the code was structured, it was very easy to follow and understand. Well done!
I've left a couple of comments with suggestions.
One other thing I noticed is that you have the same issue as I did, which is that if you try to refresh the page you end up on Netlify's error page. I found out you need to create a file in the public folder that you call _redirects. Inside it you just add /* /index.html 200. Then it will start working after you deploy :)
index.html
Outdated
| </style> | ||
|
|
||
| <!-- Preload background image --> | ||
| <link rel="preload" href="/src/assets/background_sky.jpg" as="image"> |
There was a problem hiding this comment.
I think that this preload of the background image is not working correctly. In the console it gets a 404 Not Found. Probably because it is located in the /src/assets folder. I think you need to have it in the public folder for it to work.
There was a problem hiding this comment.
Hmm I already have it stored in the public folder.
I found the problem, I had the wrong path to the public folder. Now it works! :-) Thank you!
| @@ -0,0 +1,59 @@ | |||
| /* eslint-disable react/prop-types */ | |||
| import { styled } from "styled-components"; | |||
There was a problem hiding this comment.
I really like how nice and clean your code is!
| export const Navbar = () => { | ||
| return ( | ||
| <Nav> | ||
| <NavList aria-label="Main Navigation"> |
There was a problem hiding this comment.
Great job with the aria labels 👏
src/pages/MovieInfo.jsx
Outdated
| className="movie-backdrop" | ||
| /> | ||
| </BackdropContainer> | ||
| <BackButton to="/"> |
There was a problem hiding this comment.
It would be nice if this link could be a little bit "smarter". So that if I'm on the Upcoming page and I click on a movie, then the link would take me back to the Upcoming page. Now it always leads to the home page.
There was a problem hiding this comment.
I have fixed this now :-)
…om netlify that is showing when reloading the page
Great! Thank you! I was really annoyed about that. Now it works! Thanks!! 🌟 |
… showing correct page based on location(now playing or upcoming movies) also changed text on navbar and updated now playing and upcoming movie components with origin
https://swedishmoviezone.netlify.app/