Week 9 - project-movies-vite - Mai #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
reviewed
Apr 11, 2024
Comment on lines
+8
to
+10
| if (!response.ok) { | ||
| throw new Error("Failed to load popular movies"); | ||
| } |
There was a problem hiding this comment.
I only see this right now - maybe there's something wrong with the deployed env variable (VITE_APP_API_KEY)? 👀
AntonellaMorittu
suggested changes
May 17, 2024
Hello @AntonellaMorittu and @HIPPIEKICK Sorry I missed this and now I have added env variable to netlify. Please check! |
HIPPIEKICK
requested changes
May 21, 2024
Comment on lines
+1
to
16
| import { BrowserRouter, Routes, Route } from "react-router-dom"; | ||
| import { MovieList } from "./components/MovieList/MovieList"; | ||
| import { MovieDetails } from "./components/MovieDetails/MovieDetails"; | ||
| import { NotFound } from "./components/NotFound/NotFound"; | ||
|
|
||
| export const App = () => { | ||
| return <div>Find me in src/app.jsx!</div>; | ||
| return ( | ||
| <BrowserRouter> | ||
| <Routes> | ||
| <Route path="/" element={<MovieList />} /> | ||
| <Route path="/movies/:movieId" element={<MovieDetails />} /> | ||
| <Route path="*" element={<NotFound />} /> | ||
| </Routes> | ||
| </BrowserRouter> | ||
| ); | ||
| }; |
|
|
||
| ### The Problem | ||
|
|
||
| Describe how you approached to problem, and what tools and techniques you used to solve it. How did you plan? What technologies did you use? If you had more time, what would be next? | ||
| I struggled a lot for CSS. I could not finish for loading and dropdown to change the list. I will submit for now but will to continue till it works. |
There was a problem hiding this comment.
It looks super so I think you should be proud!
|
Hey @HIPPIEKICK, I have added the back button. Please check! |
AntonellaMorittu
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link:
https://project-movies-vite-mai.netlify.app/