Happy thoughts front and back end #489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
May 22, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job Johanna, it works well 🌻
server.js
Outdated
| mongoose.Promise = Promise; | ||
| const Thought = mongoose.model("Thought", { | ||
| // this is the schema that tells the data base what kind of data we are expecting. like year-film, category and so on. | ||
| message: String, |
Contributor
There was a problem hiding this comment.
It's probably good idea to make this required
server.js
Outdated
| const Thought = mongoose.model("Thought", { | ||
| // this is the schema that tells the data base what kind of data we are expecting. like year-film, category and so on. | ||
| message: String, | ||
| hearts: Number, |
Contributor
There was a problem hiding this comment.
And to make this default to 0
server.js
Outdated
Comment on lines
32
to
38
| const thoughts = await Thought.find() | ||
| // sort by createdAt in descending order, so i get the newest thoughts first | ||
| .sort({ createdAt: "desc" }) | ||
| // limited to 20 thoughts | ||
| .limit(20) | ||
| .exec(); | ||
| res.json(thoughts); |
Contributor
There was a problem hiding this comment.
Nice and clean! Would be nice with a status code here though
server.js
Outdated
| // create a new thought and save it to the database, mongo db will create a unique id for the thought. | ||
| const newThought = new Thought({ message: req.body.message, hearts: 0 }); | ||
| newThought.save().then(() => { | ||
| res.json(newThought); |
server.js
Outdated
| thought.hearts = thought.hearts + 1 | ||
| // here is where the heart is saved to the database | ||
| thought.save().then(() => { | ||
| res.json(thought); |
server.js
Outdated
| return; | ||
| } | ||
| // add a heart to the thought | ||
| thought.hearts = thought.hearts + 1 |
Contributor
There was a problem hiding this comment.
Here you could've used $inc 👀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://happyythoughts.netlify.app/