Arnau's Happy thoughts API #488
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 27 commits
May 18, 2024 11:57
…ly apears after changing to mongoUrl path save and run again
HIPPIEKICK
reviewed
May 22, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job, but please consider adding a query of sorts if you want the user to be able to like 100 times at once, something like:
/thoughts/:id/like?amount=100
// increment by ${amount}
Comment on lines
+21
to
+27
| app.use((req, res, next) => { | ||
| if (mongoose.connection.readyState === 1) { | ||
| next(); | ||
| } else { | ||
| res.status(503).json({ error: "Service unavailable." }); | ||
| } | ||
| }); |
Comment on lines
+61
to
+68
| app.get("/thoughts", async (req, res) => { | ||
| try { | ||
| const thoughts = await Thought.find().sort({ createdAt: -1 }).limit(20); | ||
| res.status(200).json(thoughts); | ||
| } catch (error) { | ||
| res.status(400).json({ error: error.message }); | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
Nice and clean endpoint 👍
Comment on lines
+91
to
+95
| const thought = await Thought.findByIdAndUpdate( | ||
| thoughtId, | ||
| { $inc: { hearts: 1 } }, | ||
| { new: true } | ||
| ); |
| } | ||
| }); | ||
|
|
||
| app.post("/thoughts/:thoughtId/like", async (req, res) => { |
Contributor
There was a problem hiding this comment.
Haha I love the idea with 1, 10, 100 likes, but consider dealing with that from the backend side so you don't need to call your API 100 times 🙈
Author
There was a problem hiding this comment.
hehe you are right, it has to be done in the backend.
HIPPIEKICK
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
Backend: here
Frontend: here
Solo
[github-vidalhuix]