Erika's Happy Thoughts API #483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
approved these changes
May 22, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Good job and nice to see that you made it your own with the dislike endpoint. What do you think about having it as one endpoint and then using a query to specify exactly what the user wants to do? Something like:
/thoughts/mongoID?like=true
and
/thoughts/mongoID?like=false
or something, maybe with better naming. Just a thought.
Good work!
Comment on lines
+16
to
+22
| app.use((req, res, next) => { | ||
| if (mongoose.connection.readyState === 1) { | ||
| next() | ||
| } else { | ||
| res.status(503).json({ error: "Service unavailable." }) | ||
| } | ||
| }) |
| try { | ||
| const thoughts = await Thought.find().sort({ createdAt: -1 }).limit(20).exec() | ||
| if (thoughts.length > 0) { | ||
| res.json(thoughts) |
Contributor
There was a problem hiding this comment.
A status code would be nice here
| } | ||
| }) | ||
|
|
||
| app.patch("/thoughts/:id/like", async (req, res) => { |
Comment on lines
+89
to
+91
| const thought = await Thought.findByIdAndUpdate( | ||
| req.params.id, | ||
| { $inc: { hearts: 1 } }, { new: true, runValidators: true }) |
Comment on lines
+101
to
+116
| app.patch("/thoughts/:id/dislike", async (req, res) => { | ||
| try { | ||
| const thought = await Thought.findByIdAndUpdate( | ||
| req.params.id, | ||
| { $inc: { hearts: -1 } }, | ||
| { new: true, runValidators: true } | ||
| ) | ||
| res.status(200).json(thought) | ||
| } catch (error) { | ||
| res.status(400).json({ | ||
| success: false, | ||
| response: error, | ||
| message: "Could not dislike thought.", | ||
| }) | ||
| } | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://tejpex-happy-thoughts-api.onrender.com/
Collaborators
Add your collaborators here. Write their GitHub usernames in square brackets. If there's more than one, separate them with a comma, like this:
[github-username-1, github-username-2]