Happy Thoughts API #480
Closed
Happy Thoughts API #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd only have the default value.
HIPPIEKICK
approved these changes
May 22, 2024
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Nice job with the happy thoughts API 🌻
| .exec(); | ||
|
|
||
| if (allThoughts.length > 0) { | ||
| res.json(allThoughts); |
Contributor
There was a problem hiding this comment.
A status code here would be nice
|
|
||
| // Input Validation | ||
| if (!message || typeof message !== "string" || message.trim().length === 0) { | ||
| return res.status(422).json({ |
Contributor
There was a problem hiding this comment.
Never heard of 422 before, but I guess it works here 😅
Comment on lines
+96
to
+101
| const messages = Object.values(error.errors).map((err) => err.message); | ||
| return res.status(400).json({ | ||
| success: false, | ||
| error: "Validation error", | ||
| message: messages.join(". "), | ||
| }); |
Comment on lines
+118
to
+122
| const thought = await Thought.findByIdAndUpdate( | ||
| thoughtId, | ||
| { $inc: { hearts: 1 } }, | ||
| { new: true, runValidators: true } | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://mindful-and-happy.netlify.app/