Skip to content

Conversation

@Isira-Seneviratne
Copy link
Member

  • Removed the parseDuration method in TimeAgoParser, as it was not being used anywhere in the extractor or NewPipe.
  • Updated the test cases for TimeAgoParser.

@opusforlife2 opusforlife2 added the codequality Improvements to the codebase to improve the code quality label Sep 19, 2024
@litetex litetex self-requested a review January 23, 2025 19:54
Isira-Seneviratne and others added 2 commits January 23, 2025 20:56
* Dedup using parameterized tests
* Make ``now`` controllable
@litetex litetex force-pushed the TimeAgoParser-unused branch from c06b873 to 746b36e Compare January 23, 2025 20:48
Copy link
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's get this merged!

  • Rebased branch
  • Improved tests further
  • Failing tests are unrelated
  • Backported checkstyle fixes from #1263 as the build otherwise completely fails

@litetex litetex merged commit 485a77d into TeamNewPipe:dev Jan 23, 2025
3 of 4 checks passed
@litetex litetex mentioned this pull request Jan 23, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codequality Improvements to the codebase to improve the code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants