Skip to content

Bored waiting button doesnt remove itself after processing (#2079) #2235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Frooodle merged 4 commits into from
Nov 22, 2024
Merged

Bored waiting button doesnt remove itself after processing (#2079) #2235

Frooodle merged 4 commits into from
Nov 22, 2024

Conversation

@alonsofabila-dev
Copy link
Contributor

@alonsofabila-dev alonsofabila-dev commented Nov 14, 2024 •
edited
Loading

Description

hide bored waiting? button after request handling both success and error cases to properly hide the button.

Closes #(2079)

Images

during request after delay after request after error

Checklist

  • I have read the Contribution Guidelines
  • I have performed a self-review of my own code
  • I have attached images of the change if it is UI based
  • I have commented my code, particularly in hard-to-understand areas
  • If my code has heavily changed functionality I have updated relevant docs on Stirling-PDFs doc repo
  • My changes generate no new warnings
  • I have read the section Add New Translation Tags (for new translation tags only)

@dosubot dosubot bot added size:S This PR changes 10-29 lines ignoring generated files. Bug Something isn't working labels Nov 14, 2024
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Nov 14, 2024
@Frooodle
Copy link
Member

Frooodle commented Nov 17, 2024

Sorry for using your PR for testing our new automation, we needed a external user

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2024

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2235

This deployment will be automatically cleaned up when the PR is closed.

@Frooodle
Copy link
Member

Frooodle commented Nov 17, 2024

In the Demo website it seems that the bored waiting button now instantly shows instead of a delay?

@Stirling-Tools Stirling-Tools deleted a comment from github-actions bot Nov 17, 2024
@alonsofabila-dev
Copy link
Contributor Author

alonsofabila-dev commented Nov 19, 2024

yes, now the button appear while the request is being processed.

should there be a delay?

@Frooodle
Copy link
Member

Frooodle commented Nov 19, 2024

Yes previous logic had a quick delay before showing it

@alonsofabila-dev
Copy link
Contributor Author

alonsofabila-dev commented Nov 19, 2024

I cant find the delay part, do you know where it is?

@Frooodle
Copy link
Member

Frooodle commented Nov 19, 2024

https://github.com/Stirling-Tools/Stirling-PDF/blob/main/src/main/resources/static/js/downloader.js#L49-L57
and

similarly i think the logic to hide the button can probably be put here
https://github.com/Stirling-Tools/Stirling-PDF/blob/main/src/main/resources/static/js/downloader.js#L72

@dosubot dosubot bot added size:M This PR changes 30-99 lines ignoring generated files. and removed size:S This PR changes 10-29 lines ignoring generated files. labels Nov 20, 2024
@alonsofabila-dev alonsofabila-dev force-pushed the Fix-bored-waiting-button-doesnt-remove-itself-after-processing branch from f0a3d28 to 6ca97c0 Compare November 20, 2024 18:50
@dosubot dosubot bot added size:S This PR changes 10-29 lines ignoring generated files. and removed size:M This PR changes 30-99 lines ignoring generated files. labels Nov 20, 2024
@alonsofabila-dev alonsofabila-dev force-pushed the Fix-bored-waiting-button-doesnt-remove-itself-after-processing branch 2 times, most recently from 37a666c to b828f41 Compare November 20, 2024 19:00
@alonsofabila-dev
Fix: Bored waiting button doesnt remove itself after processing (Stir…
954cbfd 
…ling-Tools#2079)

hide bored waiting? button after request handling both success and error cases to properly hide the button.
@alonsofabila-dev alonsofabila-dev force-pushed the Fix-bored-waiting-button-doesnt-remove-itself-after-processing branch from b828f41 to 954cbfd Compare November 20, 2024 19:16
@alonsofabila-dev
Copy link
Contributor Author

alonsofabila-dev commented Nov 20, 2024

I have corrected the pull request, how should I address the conflicts?

@Frooodle
Copy link
Member

Frooodle commented Nov 20, 2024

I have corrected the pull request, how should I address the conflicts?

however you wish, using githubs built in resolve conflicts UI or locally and push up

@alonsofabila-dev
Copy link
Contributor Author

alonsofabila-dev commented Nov 20, 2024

done

@Frooodle
Copy link
Member

Frooodle commented Nov 20, 2024

/deployPR

@alonsofabila-dev
Copy link
Contributor Author

alonsofabila-dev commented Nov 21, 2024

what does /deployPR?

@Frooodle
Copy link
Member

Frooodle commented Nov 22, 2024

what does /deployPR?

Deploys it for my testing

@Frooodle
Copy link
Member

Frooodle commented Nov 22, 2024

/deploypr

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2024

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://185.252.234.121:2235

This deployment will be automatically cleaned up when the PR is closed.

@Stirling-Tools Stirling-Tools deleted a comment from github-actions bot Nov 22, 2024
@Frooodle Frooodle merged commit bd29dd1 into Stirling-Tools:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frooodle Frooodle Awaiting requested review from Frooodle Frooodle is a code owner

Assignees

No one assigned

Labels

Bug Something isn't working Front End Issues or pull requests related to front-end development size:S This PR changes 10-29 lines ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alonsofabila-dev @Frooodle