Skip to content

Fix NPE in DemonlordSlayer #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
My-Name-Is-Jeff merged 2 commits into from
May 10, 2025
Merged

Fix NPE in DemonlordSlayer #485

My-Name-Is-Jeff merged 2 commits into from
May 10, 2025

Conversation

@hannibal002
Copy link
Contributor

@hannibal002 hannibal002 commented May 20, 2024

totemPos can be null in DemonlordSlayer.entityJoinWorld.
This PR is just a workaround so that the error does not show up, not investigating how the NPE can occur.

java.lang.NullPointerException
	at net.minecraft.entity.Entity.func_174818_b(Entity.java:1126)
	at gg.skytils.skytilsmod.features.impl.slayer.impl.DemonlordSlayer$entityJoinWorld$1$1.invoke(DemonlordSlayer.kt:196)
	at gg.skytils.skytilsmod.features.impl.slayer.impl.DemonlordSlayer$entityJoinWorld$1$1.invoke(DemonlordSlayer.kt:187)
	at gg.skytils.skytilsmod.core.TickKt$tickTask$1$1.invokeSuspend(tick.kt:56)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at gg.skytils.ktx-coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at net.minecraft.util.Util.func_181617_a(Util.java:19)

@Kemmisch Kemmisch mentioned this pull request Mar 22, 2025
Closed
@My-Name-Is-Jeff My-Name-Is-Jeff changed the base branch from 1.x to dev May 10, 2025 05:08
@My-Name-Is-Jeff My-Name-Is-Jeff merged commit 6df31d9 into Skytils:dev May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hannibal002 @My-Name-Is-Jeff