Feature/comfy gguf models #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cohee1207
reviewed
Nov 18, 2024
Cohee1207
reviewed
Nov 18, 2024
Cohee1207
reviewed
Nov 18, 2024
Cohee1207
reviewed
Nov 18, 2024
Cohee1207
approved these changes
Nov 18, 2024
Member
Cohee1207
left a comment
Cohee1207
left a comment
There was a problem hiding this comment.
I tested and it works.
Not that it's particularly useful to regurgitate the same image over and over again, but if someone needs it - let'em have it.
Wolfsblvt
added
🟨 ⬤⬤⬤○○
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements to ComfyUI integration for img2img and Flux
Makes denoise setting available for Comfy
Strips data url part of base64-enc images... there are no b64 loaders that can handle data URLs, and PNG_PIXEL fallback is sent as plain b64, so it isn't "supposed" to be like that. Unlikely to be a breaking change because the 0 other people who have got this to work would be using a string replacement node which will turn into a noop.
Adds GGUF diffusers to Model dropdown so they can be passed to a GGUF loader without savage workarounds. I considered adding a second dropdown for diffusers or putting diffusers on a parameter other than %model%. But this would create confusion without doing anything to prevent user footgunning.
Adds a second sample workflow for Comfy to demonstrate img2img. I don't know what the position on adding content is these days, but if Comfy supports %char_avatar% it seems useful to provide a workflow for it
Checklist: