Enhancement: Make buttons scrollable #3004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joenunezb
changed the title
Cohee1207
reviewed
Oct 21, 2024
public/scripts/slash-commands.js
Outdated
| buttonContainer.classList.add('flex-container', 'flexFlowColumn', 'wide100p'); | ||
|
|
||
| const scrollableContainer = document.createElement('div'); | ||
| scrollableContainer.style.maxHeight = '50vh'; // Use viewport height instead of fixed pixels |
Member
There was a problem hiding this comment.
Try not to mix styles with code. Move that to a CSS file and set a class.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I'll get to this on the weekend and will push out a commit.
Contributor
Author
There was a problem hiding this comment.
@Cohee1207 , I've addressed the comment and re-tested. Would you like me to re-upload videos of the feature still working? I tested on mobile and PC.
…com/joenunezb/SillyTavern into enhancement-make-buttons-scrollable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a simple scrollbar to buttons created via
/buttonscommand. Tested with a simple QR CoT script. I also clicked around with LenAnderson's Codex and did not see any particular regressions.No errors reported in console log, tested a few variations of sizes with Chrome's device toolbar and everything looked fine.
Before:
PC:
before_Recording.2024-10-21.002601.mp4
Mobile (bonus):
before_Screen_Recording_20241021_002741_Chrome.mp4
After:
PC:
after_Recording.2024-10-21.000650.mp4
Mobile (bonus):
Screen_Recording_20241021_000517_Chrome.mp4
Checklist: