Skip to content

Conversation

@InspectorCaracal
Copy link
Contributor

@InspectorCaracal InspectorCaracal commented Oct 15, 2024

The current UX for deleting multiple chat messages at once only allows you to crop the tail of the chat log by selecting the message you click on, then automatically selecting all other messages between it and the end of the chat history.

This PR replaces that behavior with the following behaviors:

  • Individual messages can be marked or unmarked for deletion by clicking them.
  • A range of messages can be marked or unmarked for deletion by clicking the first message, then holding Ctrl and clicking the second message.

Checklist:

Copy link
Member

@Cohee1207 Cohee1207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. For many this is going to break muscle memory since delete worked like this from the very beginning. I'm not going to ask to add a toggle, since no one likes toggles, but inverting this behavior would be nicer.
  2. There are no visual clues about using keyboard for selecting ranges. Add a little hint above the "Delete" / "Cancel".
  3. Ctrl+Click doesn't really work for Mac (it opens a context menu). And we already have several Shift+Clicks across the app, so I suggest to switch to Shift modifier.
  4. Not really a major issue (at least for me), but mobile is gimped by having no way to replicate the Shift+Click behavior.

@Cohee1207
Copy link
Member

The last review point could be mitigated by allowing to long-tap to select/deselect a single message

@InspectorCaracal
Copy link
Contributor Author

InspectorCaracal commented Oct 15, 2024

  1. For many this is going to break muscle memory since delete worked like this from the very beginning. I'm not going to ask to add a toggle, since no one likes toggles, but inverting this behavior would be nicer.

I'm probably just being obtuse, but what does "inverting this behavior" mean? Oh, I got it, you mean regular clicks to (de)select ranges and shift-clicks to (de)select individual items. 👍

  1. Ctrl+Click doesn't really work for Mac (it opens a context menu). And we already have several Shift+Clicks across the app, so I suggest to switch to Shift modifier.

This might be a little tricky, but I'll give it a shot. I originally set it up with Shift but that winds up actually selecting text in the page, which was super annoying, so I'll have to figure out why and then figure out if changing the cause of that breaks anything else in the process.

@Cohee1207
Copy link
Member

I originally set it up with Shift but that winds up actually selecting text in the page

Hmm, probably need to call preventDefault on the event or something along these lines

@Cohee1207 Cohee1207 linked an issue Nov 13, 2024 that may be closed by this pull request
@Cohee1207 Cohee1207 added the 🔨 Needs Work [PR] Needs more work / changes requested label Nov 18, 2024
@Cohee1207 Cohee1207 mentioned this pull request Feb 18, 2025
@InspectorCaracal InspectorCaracal deleted the chatdelete-checkboxes branch May 1, 2025 20:58
@github-actions github-actions bot removed the 🔨 Needs Work [PR] Needs more work / changes requested label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Ability to delete any segment of the chat

2 participants