feat: added onboarding detail for consumer setup #6372
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 51db6cb in 39 seconds
More details
- Looked at
74lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/constants/apmDocFilePaths.ts:255
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools. This applies to other similar imports in this file as well. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_e59asmWpduLQINAV
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
...les/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-consumers.md
Outdated
Show resolved
Hide resolved
...les/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-consumers.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2381a6c in 14 seconds
More details
- Looked at
25lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/Modules/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-consumers.md:3
- Draft comment:
No issues found in this markdown file as it doesn't contain any code violating the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The provided files are markdown documentation files, and they do not contain any code that violates the specified rules. Therefore, no comments are necessary for these files.
2. frontend/src/container/OnboardingContainer/Modules/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-producer.md:3
- Draft comment:
No issues found in this markdown file as it doesn't contain any code violating the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The provided files are markdown documentation files, and they do not contain any code that violates the specified rules. Therefore, no comments are necessary for these files.
Workflow ID: wflow_cWxzpEzQ28bGIz9A
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
SagarRajput-7
dismissed stale reviews from YounixM, rahulkeswani101, and ahmadshaheer
via
5d21ae9
SagarRajput-7
force-pushed
the
SIG-1905-consumer
branch
from
64c616b to
5d21ae9
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 5d21ae9 in 35 seconds
More details
- Looked at
25lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/Modules/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-consumers.md:3
- Draft comment:
No issues found with the specified rules in this PR. - Reason this comment was not posted:
Confidence changes required:0%
The PR does not violate any of the specified rules. The changes are documentation updates and do not involve code that could violate the rules about design tokens, inline styles, ClickHouseReader interface, or file structure.
Workflow ID: wflow_zm4UviM24aXWXUYo
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
...les/APM/Java/md-docs/SpringBoot/Kubernetes/springBoot-kubernetes-runApplication-consumers.md
Show resolved
Hide resolved
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 1fb2b78 in 39 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/container/OnboardingContainer/constants/apmDocFilePaths.ts:254
- Draft comment:
The import statement forAPM_java_springBoot_kubernetes_recommendedSteps_runApplication_producerswas moved but not modified. Consider reverting this change to avoid unnecessary diff noise. - Reason this comment was not posted:
Confidence changes required:50%
The import statement forAPM_java_springBoot_kubernetes_recommendedSteps_runApplication_producerswas moved but not modified, which is unnecessary and could lead to confusion.
2. frontend/src/container/OnboardingContainer/constants/apmDocFilePaths.ts:252
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_sVuC9r57gkISleZq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add documentation for Java consumer setup in Kubernetes and update related constants.
springBoot-kubernetes-runApplication-consumers.mdfor Java consumer setup in Kubernetes.springBoot-kubernetes-runApplication-producers.mdto remove consumer app references.APM_java_springBoot_kubernetes_recommendedSteps_runApplication_consumerstoapmDocFilePaths.ts.This description was created by
for 1fb2b78. It will automatically update as commits are pushed.