feat: added healthcheck and attribute checklist component for Kafka #6371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 912a4cb in 1 minute and 29 seconds
More details
- Looked at
853lines of code in12files - Skipped
0files when reviewing. - Skipped posting
5drafted comments based on config settings.
1. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.tsx:44
- Draft comment:
Useincludesinstead offilterto check for the presence of a service.
enabled: serviceToInclude.includes(MessagingQueueHealthCheckService.Producers),
- Reason this comment was not posted:
Marked as duplicate.
2. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.tsx:58
- Draft comment:
Useincludesinstead offilterto check for the presence of a service.
enabled: serviceToInclude.includes(MessagingQueueHealthCheckService.Kafka),
- Reason this comment was not posted:
Marked as duplicate.
3. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.styles.scss:44
- Draft comment:
Avoid using inline styles forheightin.attribute-select .ant-select-selector. Use a CSS class instead. - Reason this comment was not posted:
Comment looked like it was already resolved.
4. frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.styles.scss:162
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values forborderin.config-btn-content. - Reason this comment was not posted:
Marked as duplicate.
5. frontend/src/pages/MessagingQueues/MessagingQueues.styles.scss:67
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding color values forborderin.messaging-queue-options .ant-select-selector. This is also applicable to other similar instances in this file. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_uI7hNq4ZHZv899po
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
frontend/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.tsx
Show resolved
Hide resolved
...nd/src/pages/MessagingQueues/MessagingQueueHealthCheck/MessagingQueueHealthCheck.styles.scss
Show resolved
Hide resolved
rahulkeswani101
approved these changes
Nov 5, 2024
ahmadshaheer
approved these changes
Nov 5, 2024
YounixM
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / PR's
Screenshots
Attribute Checklist -
Screen.Recording.2024-10-24.at.9.55.09.AM.mov
Affected Areas and Manually Tested Areas
Important
Add Kafka health check and onboarding components, update UI and documentation for Kafka services.
getOnboardingStatusfunction ingetOnboardingStatus.tsto fetch Kafka onboarding status.useOnboardingStatushook inuseOnboardingStatus.tsxfor querying onboarding status.MessagingQueueHealthCheckandAttributeCheckListcomponents for Kafka health checks.ConnectionStatus.tsxto handle Kafka-specific onboarding logic.MessagingQueueHealthCheck.styles.scssfor new components.springBoot-kubernetes-runApplication-producers.mdfor Java producer setup.getStartedSourceandgetStartedSourceServicetoQueryParamsenum inquery.ts.messagingQueueKakfaSupportedDataSourcesindataSourceUtils.ts.MessagingQueues.tsxto include health check modal and navigation logic.This description was created by
for 912a4cb. It will automatically update as commits are pushed.