fix: add safety check to check if anomaly rule in uplot chart options #6343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c9a0d6c in 16 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/lib/uPlotLib/getUplotChartOptions.ts:167
- Draft comment:
Good use of optional chaining and default value to prevent runtime errors when accessingisAnomaly. - Reason this comment was not posted:
Confidence changes required:0%
The change made in the PR is a safety check to ensure thatisAnomalyis accessed safely. This is a good practice to prevent runtime errors when the data structure is not as expected.
2. frontend/src/lib/uPlotLib/getUplotChartOptions.ts:167
- Draft comment:
Use design tokens or predefined color constants instead of hardcoding 'red'. This applies to other hardcoded colors like 'white' and '#fff' as well. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_5IlZKgssaIFrrXmX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
SagarRajput-7
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://signoz-io.sentry.io/issues/6034450498/?alert_rule_id=15272042&alert_type=issue&project=4506831143763968
Important
Add safety check for
isAnomalyproperty ingetUplotChartOptionsto prevent undefined errors.isAnomalyproperty ingetUplotChartOptionsingetUplotChartOptions.tsto default tofalseif undefined.This description was created by
for c9a0d6c. It will automatically update as commits are pushed.