feat(integrations): whitelist /deployments/me #6275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to e308716 in 6 seconds
More details
- Looked at
15lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. ee/query-service/integrations/gateway/proxy.go:13
- Draft comment:
Ensure that the addition of "/v2/deployments/me" to the AllowedPrefix list is properly tested to confirm that it behaves as expected in the application. - Reason this comment was not posted:
Confidence changes required:50%
The PR adds "/v2/deployments/me" to the AllowedPrefix list, which is consistent with the PR description. The change is straightforward and aligns with the intent to whitelist this endpoint.
2. ee/query-service/integrations/gateway/proxy.go:13
- Draft comment:
No issues found with the specified rules. - Reason this comment was not posted:
Confidence changes required:0%
The code does not violate any of the specified rules. It does not use hardcoded color values, inline styles, or inappropriate file structures. The ClickHouseReader interface is not involved here.
Workflow ID: wflow_p1qlmU66ly8yuoT4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Whitelist /deployments/me for updating host in signoz cloud
Important
Add
/v2/deployments/metoAllowedPrefixinproxy.goto whitelist this endpoint./v2/deployments/metoAllowedPrefixinproxy.goto whitelist this endpoint for updating host in Signoz Cloud.This description was created by
for e308716. It will automatically update as commits are pushed.