Fix: logs pipelines: ensure special characters in pipeline identifiers don't result in bad collector config names #6259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6f78c27 in 11 seconds
More details
- Looked at
98lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/app/logparsingpipeline/pipelineBuilder.go:23
- Draft comment:
The regex pattern used here effectively replaces all non-alphanumeric characters and hyphens with a hyphen, ensuring valid collector config names. This addresses the issue of invalid characters in pipeline aliases. - Reason this comment was not posted:
Confidence changes required:0%
The PR introduces a regex to replace invalid characters in pipeline aliases with a hyphen. This ensures that the generated collector config names are valid. The test added verifies this behavior by checking that a pipeline alias with a pipe character does not break the collector config. The implementation seems correct and addresses the issue described in the PR.
2. pkg/query-service/app/logparsingpipeline/pipelineBuilder.go:23
- Draft comment:
The regex[^a-zA-Z0-9-]ensures that only valid characters are used in collector config names, resolving the issue with special characters in pipeline aliases. - Reason this comment was not posted:
Confidence changes required:0%
The code uses a regex to replace invalid characters in pipeline aliases, which resolves the issue of invalid characters in collector config names.
Workflow ID: wflow_2uTYWW44HbayWfR3
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Base automatically changed from
chore/upgrade-signoz-otel-collector-dependency-to-v0.111.2
to
develop
October 28, 2024 05:15
raj-k-singh
force-pushed
the
fix/logs-pipelines-pipe-char-in-alias-breaks-config
branch
from
6f78c27 to
05df623
Compare
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 05df623 in 9 seconds
More details
- Looked at
98lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/app/logparsingpipeline/pipelineBuilder.go:23
- Draft comment:
The regex pattern used inbadCharsForCollectorConfNamecorrectly replaces non-alphanumeric characters with-, ensuring valid collector config names. - Reason this comment was not posted:
Confidence changes required:0%
The regex pattern used inbadCharsForCollectorConfNameis correct for replacing non-alphanumeric characters with-. This ensures that the pipeline identifiers are normalized as intended.
2. pkg/query-service/app/logparsingpipeline/pipelineBuilder.go:25
- Draft comment:
The functionCollectorConfProcessorNamecorrectly normalizes the alias by replacing non-alphanumeric characters with-. This resolves the issue of invalid collector config names due to special characters. - Reason this comment was not posted:
Confidence changes required:0%
The functionCollectorConfProcessorNamecorrectly normalizes the alias by replacing non-alphanumeric characters with-. This resolves the issue of invalid collector config names due to special characters.
Workflow ID: wflow_qDD8nJtMnBPkK3KK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nityanandagohain
approved these changes
Oct 28, 2024
raj-k-singh
deleted the
fix/logs-pipelines-pipe-char-in-alias-breaks-config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ensures special characters in pipeline identifiers don't result in bad collector config names
Fixes #6253
Important
Normalize pipeline identifiers to ensure valid collector config names despite special characters.
CollectorConfProcessorNameinpipelineBuilder.goby replacing non-alphanumeric characters with-.TestPipeCharInAliasDoesntBreakCollectorConfigincollector_config_test.goto verify special characters in pipeline aliases do not break collector config generation.This description was created by
for 05df623. It will automatically update as commits are pushed.