Fix/bulk invite api error response #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 5a7e597 in 49 seconds
More details
- Looked at
28lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/app/parser.go:752
- Draft comment:
Removing the name validation might cause issues if the name is required elsewhere. Ensure this change aligns with application requirements. - Reason this comment was not posted:
Comment did not seem useful.
2. pkg/query-service/app/parser.go:752
- Draft comment:
Ensure all necessary fields are validated inparseInviteUsersRequest. The removal of name validation is fine, but other fields should still be checked. - Reason this comment was not posted:
Confidence changes required:50%
The removal of the name validation in theparseInviteUsersRequestfunction is correct as it aligns with the PR's goal to handle bulk invite errors more gracefully. However, the function should still ensure that all necessary fields are validated.
Workflow ID: wflow_Ol0QeRYQph8aa1Sf
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
grandwizard28
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Respond with 400 in case of failures. Since it is a bulk API which can have multiple types of failures, so according to discussion with frontend team, we have decided to use 400 as common failure code with failure details in json
Important
Change bulk invite API to return 400 status code for failures.
inviteUsers()inhttp_handler.go.http_handler.go.This description was created by
for 5a7e597. It will automatically update as commits are pushed.