chore: add missing shiftby in alert rule #6239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ca5c756 in 42 seconds
More details
- Looked at
259lines of code in5files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. pkg/query-service/model/v3/v3.go:793
- Draft comment:
Consider adding a check for an emptyArgslist inSetShiftByFromFuncto prevent potential panics. Log an error ifArgsis empty, as this is an unexpected state. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The function already checks for the length ofArgsbefore accessing it, so there is no risk of a panic. The suggestion to log an error ifArgsis empty is more about logging unexpected states rather than preventing a panic. This could be considered a code quality improvement, but it's not strictly necessary for functionality.
I might be underestimating the importance of logging unexpected states for debugging purposes. Logging could help in identifying issues during runtime that are not immediately apparent.
While logging unexpected states can be useful, the absence of such logging does not constitute a functional issue. The current implementation prevents panics, which is the primary concern.
The comment suggests a code quality improvement by logging unexpected states, but it is not necessary for functionality. The function already prevents panics by checking the length ofArgs.
2. pkg/query-service/app/parser.go:1145
- Draft comment:
Avoid using thecomponent/index.tsxfile structure approach, as it makes it difficult to debug and find components using global search tools like VS Code. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_FeDb6yhV4gFprvG9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #6151
Prior to this change, shift by happened only during the
/query_range, making the alert created with shift by useless.Important
Add
shiftByfunctionality to alert rules by implementingSetShiftByFromFunc()inBuilderQueryand applying it in query parsing and preparation.SetShiftByFromFunc()method toBuilderQueryinv3.goto handleshiftByfunctionality.SetShiftByFromFunc()inParseQueryRangeParamsinparser.goandprepareQueryRangeinthreshold_rule.goto setshiftByduring alert rule creation.parser_test.goandthreshold_rule_test.goto verifyshiftByfunctionality for builder queries withtimeShiftfunction.ParseQueryRangeParamsinparser.goto useSetShiftByFromFunc()for cleaner code.This description was created by
for ca5c756. It will automatically update as commits are pushed.