fix: updated the triggered alert list code #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
vikrantgupta25
approved these changes
Oct 7, 2024
|
@rahulkeswani101 : Please add the issue details. |
|
A brief about what is the issue, how are we solving it helps co-relate PR with functionality and helps review PR faster. |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
YounixM
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The triggered alert list fetches the data every 30 seconds and because of this filter states were getting reset to initial values. I moved the state to the parent component where we were fetching the data for all triggered alerts. Because of this my filter and group by state don't get reset as it was getting reset before because of the children component getting re-render.
Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/1868
Screen.Recording.2024-10-06.at.9.07.43.PM.mov
Affected Areas and Manually Tested Areas