Skip to content

fix: hide PromQL from table panel type #6117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 9, 2024
Merged

fix: hide PromQL from table panel type #6117

merged 5 commits into from
Oct 9, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Oct 3, 2024

Summary

Removed PromQL tab from table panel type

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/1441

Screenshots

Screen.Recording.2024-10-04.at.4.15.47.PM.mov

Affected Areas and Manually Tested Areas

  • tested dashboard edit mode with different panel types
  • tested panel type switch and default query-type selection - (like should switch to query-builder type when switching to panel type to table panel)

@SagarRajput-7 SagarRajput-7 requested a review from YounixM as a code owner October 3, 2024 17:16
Copy link

github-actions bot commented Oct 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Oct 3, 2024
Copy link

github-actions bot commented Oct 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

github-actions bot commented Oct 4, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

rahulkeswani101
rahulkeswani101 previously approved these changes Oct 4, 2024
vikrantgupta25
vikrantgupta25 previously approved these changes Oct 4, 2024
Copy link
Member

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Oct 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 merged commit a24fb5d into develop Oct 9, 2024
12 of 13 checks passed
@SagarRajput-7 SagarRajput-7 deleted the SIG-1441 branch October 9, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants