fix: restricted column long value to 3 line and line clamped#6056
Merged
SagarRajput-7 merged 7 commits intodevelopfrom Sep 30, 2024
Merged
fix: restricted column long value to 3 line and line clamped#6056SagarRajput-7 merged 7 commits intodevelopfrom
SagarRajput-7 merged 7 commits intodevelopfrom
Conversation
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
2 similar comments
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
frontend/src/periscope/components/LineClampedText/LineClampedText.tsx
Outdated
Show resolved
Hide resolved
vikrantgupta25
previously approved these changes
Sep 24, 2024
rahulkeswani101
previously approved these changes
Sep 24, 2024
ahmadshaheer
previously approved these changes
Sep 24, 2024
frontend/src/periscope/components/LineClampedText/LineClampedText.tsx
Outdated
Show resolved
Hide resolved
YounixM
previously approved these changes
Sep 24, 2024
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
This was referenced Sep 25, 2024
SagarRajput-7
dismissed stale reviews from YounixM, ahmadshaheer, rahulkeswani101, and vikrantgupta25
via
4a2d582
SagarRajput-7
force-pushed
the
SIG-1691
branch
3 times, most recently
from
6a48266 to
fa78ab4
Compare
rahulkeswani101
previously approved these changes
Sep 26, 2024
SagarRajput-7
requested review from
YounixM,
ahmadshaheer and
vikrantgupta25
YounixM
previously approved these changes
Sep 26, 2024
ahmadshaheer
previously approved these changes
Sep 26, 2024
SagarRajput-7
dismissed stale reviews from vikrantgupta25, ahmadshaheer, YounixM, and rahulkeswani101
via
e3a0904
SagarRajput-7
force-pushed
the
SIG-1691
branch
from
e3a0904 to
73f6e77
Compare
frontend/src/container/NewDashboard/DashboardVariablesSelection/VariableItem.tsx
Outdated
Show resolved
Hide resolved
SagarRajput-7
force-pushed
the
SIG-1691
branch
from
73f6e77 to
c51d068
Compare
SagarRajput-7
requested review from
YounixM,
ahmadshaheer,
rahulkeswani101 and
vikrantgupta25
rahulkeswani101
approved these changes
Sep 27, 2024
YounixM
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
lineclampingto the table panel column values - lines - 3, did not restricted them to any max-width (column) as columns are resizableRelated Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/1691
Screenshots
Affected Areas and Manually Tested Areas