Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: telemetry nil pointer error fix #6051

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: telemetry nil pointer error fix #6051

merged 1 commit into from
Sep 23, 2024

Conversation

nityanandagohain
Copy link
Member

Fixes nil pointer error for heartbeat func

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Sep 23, 2024
@nityanandagohain nityanandagohain merged commit f69aaa2 into develop Sep 23, 2024
12 of 13 checks passed
@nityanandagohain nityanandagohain deleted the hotfix/telemetry branch September 23, 2024 07:45
@prashant-shahi
Copy link
Member

FYI, there are other instances of the missing error handling in the same block.

@nityanandagohain
Copy link
Member Author

those are fine, we are not looking inside them.
if they are nil they will be sent as nil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashant-shahi prashant-shahi prashant-shahi approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nityanandagohain @prashant-shahi