Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tlemetry for dashboard/alerts/views using contains on attributes #6034

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix: tlemetry for dashboard/alerts/views using contains on attributes #6034

merged 4 commits into from
Sep 20, 2024

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Sep 19, 2024 •
edited
Loading

  • for alerts, dashboards and saved views checking how many are using like with attributes.
  • update existing telemetry to check for clickhouse query only if the query type is clickhouse_sql.

@github-actions github-actions bot added the bug Something isn't working label Sep 19, 2024
@SigNoz SigNoz deleted a comment from github-actions bot Sep 19, 2024
@SigNoz SigNoz deleted a comment from github-actions bot Sep 19, 2024
@nityanandagohain nityanandagohain marked this pull request as ready for review September 19, 2024 18:01
srikanthccv
srikanthccv reviewed Sep 20, 2024
View reviewed changes
pkg/query-service/app/dashboards/model.go Outdated Show resolved Hide resolved
pkg/query-service/app/dashboards/model.go Outdated Show resolved Hide resolved
pkg/query-service/app/dashboards/model.go Show resolved Hide resolved
@nityanandagohain nityanandagohain merged commit f6d3f95 into develop Sep 20, 2024
12 of 13 checks passed
@nityanandagohain nityanandagohain deleted the fix/logs-telemetry branch September 20, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nityanandagohain @srikanthccv