fix: fix incorrect alert history state #5898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
ahmadshaheer
force-pushed
the
fix/incorrect-alert-history-state
branch
from
1998a94 to
b37f4e8
Compare
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
ahmadshaheer
force-pushed
the
fix/incorrect-alert-history-state
branch
from
b37f4e8 to
edd492c
Compare
YounixM
approved these changes
Oct 4, 2024
rahulkeswani101
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixed the incorrect alert state in enable/disable switch. the issue was caused by old disabled state (from another alert). fixed by removing the old state on unmount.
Related Issues / PR's
Screenshots
Before:
After:
https://www.loom.com/share/9b15bc0edbf2439a90b5349e19562e6e
NA
Affected Areas and Manually Tested Areas