Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added start and end time info text to educate user better around the schedule timelines #5837

Merged
merged 5 commits into from
Sep 6, 2024
Merged

fix: added start and end time info text to educate user better around the schedule timelines #5837

merged 5 commits into from
Sep 6, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Sep 3, 2024 •
edited
Loading

Summary

- Does not repeat
    - StartTime 
      - Schedule will start at 22:00 on 1st Aug 2024
    - EndTime
      - Schedule will end at 22:00 on 2nd Aug 2024

- Recurrence -
    - StartTime
    (daily)
      - Schedule will start from 1st Aug 2024 and will trigger at 22:00 daily
    (monthly)
      - Schedule will start from 6th Aug 2024 and will trigger at 22:00 on 6th day of every month
    (weekly)
      - Schedule will start from 6th Aug 2024 and will trigger at 22:00 on [Monday, Wednesday] every week.

    - EndTime
      - Schedule will end at 22:00 on 2nd Aug 2024

Related Issues / PR's

https://github.com/SigNoz/engineering-pod/issues/1712

Screenshots

  • Fixed schedule:
image
  • Recurrence - daily -
image
  • Recurrence - monthly -
image
  • Recurrence - weekly -
image

Video -

Screen.Recording.2024-09-03.at.11.22.06.AM.mov

Affected Areas and Manually Tested Areas

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Sep 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@SagarRajput-7 SagarRajput-7 force-pushed the schedule-maintainence-text-msg branch from d3948ef to a90318d Compare September 3, 2024 05:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

@SagarRajput-7 looks good to me. Just some wording suggestions.

start

fixed:

Scheduled for September 5, 2024 starting at 13:36

daily:

Scheduled from September 5, 2024, daily starting at 13:36.

weekly:

Scheduled from September 5, 2024, weekly on Mondays and Wednesdays starting at 13:36

monthly:

Scheduled from September 5, 2024, monthly on the 5th starting at 13:36

end

Scheduled to end maintenance on September 27, 2024 at 13:37.

@SagarRajput-7 SagarRajput-7 force-pushed the schedule-maintainence-text-msg branch from cc8557f to f86567f Compare September 5, 2024 12:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

ahmadshaheer
ahmadshaheer reviewed Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@ahmadshaheer ahmadshaheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the existing comments, rest LGTM.

vikrantgupta25
vikrantgupta25 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@vikrantgupta25 vikrantgupta25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SagarRajput-7 SagarRajput-7 merged commit 4eb533f into develop Sep 6, 2024
12 checks passed
@SagarRajput-7 SagarRajput-7 deleted the schedule-maintainence-text-msg branch September 6, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@vikrantgupta25 vikrantgupta25 vikrantgupta25 approved these changes

@rahulkeswani101 rahulkeswani101 rahulkeswani101 approved these changes

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

@ahmadshaheer ahmadshaheer Awaiting requested review from ahmadshaheer

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SagarRajput-7 @srikanthccv @YounixM @ahmadshaheer @vikrantgupta25 @rahulkeswani101