-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: add support for changing the font size in logs #5739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
@vikrantgupta25 can we decrease the padding/spacing between the lines by 2-4px when the font is small? Looks like a lot of space there rn. |
done @GeekBoySupreme |
Looks good. |
default to small? |
this will only be for the first time user opens the page, after that whatever the user selects will be stored as a preference and used subsequently, Kept the default medium so that once this is deployed users shouldn't feel a sudden jerk of reduced size. can change it to small if you think otherwise. cc @ankitnayan |
I want to keep small as default since many users have asked to reduce size already. I want to see this in staging though before confirmation. If video is good enough proxy, I am okay with small size |
okay , reduced the default to small rather than medium ✅ |
@vikrantgupta25 : We need to centralize the decisions related to styles we have taken for this change. let's collate all the style changes for small / medium / large as PR comment so that we have documentation for the same whenever want to loop back to this. |
Summary
this PR adds the support to change the font size to
small
/medium
/large
in the logs explorer pagesDesign :- https://github.com/SigNoz/engineering-pod/issues/1205#issuecomment-1953604809
Related Issues / PR's
fixes - https://github.com/SigNoz/engineering-pod/issues/1205
contributes to - #5169
Screenshots
Screen.Recording.2024-08-22.at.12.19.44.AM.mov
Affected Areas and Manually Tested Areas