fix: clean out the panel type change attribute dependency #5648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
2 tasks
srikanthccv
reviewed
Aug 8, 2024
|
I found bugs that are unrelated to this change. So far it looks good to me. I will do some more testing. |
|
i found one issue with moving from list panel to other panel types when list panel was the first one to be opened. fixing this. |
this is fixed. |
srikanthccv
approved these changes
Aug 10, 2024
YounixM
approved these changes
Aug 11, 2024
raj-k-singh
pushed a commit
that referenced
this pull request
Aug 15, 2024
* fix: clean out the panel type change attribute dependency * fix: clean out the updater function as well * fix: issue with rendering list panel as first and then moving around
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
attribute to datasource to panel type mapand added the missing attributeshandleQueryChangefunction as wellRelated Issues / PR's
fixes https://github.com/SigNoz/engineering-pod/issues/1620
fixes #5644
fixes #5575
Screenshots
NA
Affected Areas and Manually Tested Areas