chore(telemetry): add telemetry for metrics query type and count prom… #5627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e span metrics alerts
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
makeavish
reviewed
Aug 2, 2024
makeavish
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e span metrics alerts
We added the
spanmetrics/deltapipeline because it's efficient at querying and reduces the memory needed for the collector. To remain backward compatible we kept thespanmetrics/cumulativepipeline. We have seen delta working well for long enough now. I want to remove the cumulative pipeline for everyone. Before I do that I plan to get an idea of who is using prom alerts based on span metrics, as removing the cumulative pipeline makes alerts not work correctly.See thread for some more context https://signoz-team.slack.com/archives/C06045Z9163/p1722405396987279?thread_ts=1722354481.521489&cid=C06045Z9163