fix: added card to show message for deleted alert id #5565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
@rahulkeswani101 - Did you get the mock for this, as IMO the font and in general UX don't match our pattern. cc: @GeekBoySupreme - for a quick look |
|
Please take care of lightMode also once, if not done |
|
LGTM for now. We can improve on this later. |
YounixM
reviewed
Jul 26, 2024
ahmadshaheer
reviewed
Aug 5, 2024
ahmadshaheer
previously approved these changes
Aug 6, 2024
vikrantgupta25
approved these changes
Aug 6, 2024
YounixM
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added card to show message for deleted alerts
Related Issues / PR's
1468
Screenshots
Before changes
After changes
