Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added link for dashboard name #5544

Merged
merged 6 commits into from
Aug 6, 2024
Merged

feat: added link for dashboard name #5544

merged 6 commits into from
Aug 6, 2024

Conversation

rahulkeswani101
Copy link
Contributor

@rahulkeswani101 rahulkeswani101 commented Jul 24, 2024

Summary

Added open in new tab option for dashboard name

Related Issues / PR's

#5412

Before Code Changes

image

After Code Changes

image

@github-actions github-actions bot added the enhancement New feature or request label Jul 24, 2024
ahmadshaheer
ahmadshaheer previously approved these changes Jul 24, 2024
ahmadshaheer
ahmadshaheer previously approved these changes Jul 24, 2024
Copy link
Collaborator

@ahmadshaheer ahmadshaheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , thanks for making the change 🙂

SagarRajput-7
SagarRajput-7 previously approved these changes Jul 24, 2024
@vikrantgupta25
Copy link
Collaborator

can you please a small video showing the changes? helps quickly access the visual aspects of the same

@rahulkeswani101
Copy link
Contributor Author

@vikrantgupta25 I have added screenshots for the changes above.

@YounixM
Copy link
Member

YounixM commented Jul 29, 2024

@rahulkeswani101 : We can maintain the white color for the text. Design had white text color for the dashboard name

ahmadshaheer
ahmadshaheer previously approved these changes Aug 5, 2024
Copy link
Collaborator

@ahmadshaheer ahmadshaheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of the comments by Yunus. Rest LGTM.

@vikrantgupta25
Copy link
Collaborator

@rahulkeswani101 please add the updated screen shot

@YounixM YounixM merged commit 80a7b9d into develop Aug 6, 2024
11 of 12 checks passed
@srikanthccv srikanthccv deleted the SIG-5412 branch September 12, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants