Add Active Record AssociationLoader and RecordLoader examples #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, should help newcomers a lot. I wrote this a while ago for an easy plug and play solution in graphql ruby: https://github.com/xuorig/graphql-active_record_batcher might be cool to link it 🤷♂️ |
|
I love the way fields preloads are specified declaratively in a similar way to how we do it at Shopify. Maybe we should just add the examples to that repo and link to it instead. The gemspec in that repo could also use a github link so that the repo can be easily found from its rubygems page |
xuorig
approved these changes
Aug 15, 2017
Yes, please. If you add a RecordLoader to your repo, then we could just link directly to the loaders in that repo and won't need examples in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
This adds a couple of examples for a RecordLoader and AssociationLoader that work with Active Record and links to those examples in the README.
Each of these handle a problem that a naive loader would have:
These are just examples, since I didn't want to add an active record dependency to this library.