Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polyfills for .NET 9 attributes. #108

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

teo-tsirpanis
Copy link
Contributor

API breakdown (for new features)

Polyfills for the following attributes were added:

  • [OverloadResolutionPriority]
  • [ParamsCollection]

Polyfills for the following runtime-supported attributes were added:

  • [DisableUserUnhandledExceptions]
  • [FeatureGuard]
  • [FeatureSwitchDefinition]
  • [WasmImportLinkage]

Some of the runtime-supported attributes like the first and the last, might be considered too niche to polyfill. I'd be fine with removing them from the PR.

Additional context (optional)

The list of attributes was populated by searching for the string Attribute { in files matching release-notes/9.0/**/Microsoft.NETCore.App in the dotnet/core repository, and excluding the attributes in System.Text.Json.

Test coverage for the language support polyfills was added.

@teo-tsirpanis
Copy link
Contributor Author

@Sergio0694 could you take a look now that .NET 9 released? Thanks.

@Sergio0694
Copy link
Owner

Yup, on my todo list! Waiting for GitHub Actions to update the VM images to include the .NET 9 SDK 🙂

@bgrainger
Copy link

Waiting for GitHub Actions to update the VM images to include the .NET 9 SDK

If you add setup-dotnet to your GHA workflow, it will install the SDK version specified by global.json: #113

Copy link
Owner

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🙂

@Sergio0694 Sergio0694 merged commit 06e5008 into Sergio0694:main Nov 20, 2024
5 checks passed
@teo-tsirpanis teo-tsirpanis deleted the net9 branch November 20, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Add support for OverloadResolutionPriorityAttribute
3 participants