-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add polyfills for .NET 9 attributes. #108
Conversation
@Sergio0694 could you take a look now that .NET 9 released? Thanks. |
Yup, on my todo list! Waiting for GitHub Actions to update the VM images to include the .NET 9 SDK 🙂 |
If you add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you! 🙂
API breakdown (for new features)
Polyfills for the following attributes were added:
[OverloadResolutionPriority]
[ParamsCollection]
Polyfills for the following runtime-supported attributes were added:
[DisableUserUnhandledExceptions]
[FeatureGuard]
[FeatureSwitchDefinition]
[WasmImportLinkage]
Some of the runtime-supported attributes like the first and the last, might be considered too niche to polyfill. I'd be fine with removing them from the PR.
Additional context (optional)
The list of attributes was populated by searching for the string
Attribute {
in files matchingrelease-notes/9.0/**/Microsoft.NETCore.App
in thedotnet/core
repository, and excluding the attributes inSystem.Text.Json
.Test coverage for the language support polyfills was added.