Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SeedSigner fork of embit w/secp256k1 binary for Pi Zero #221

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jun 12, 2022

Points to the specific PR merge that included the libsecp256k1 binary compiled for the Pi Zero (armv6l).

Compiled binary speeds up basic ECDSA math by roughly 8.5k, depending on the task.

Updates SeedSigner to embit v0.4.14.

SeedSigner image must be updated with a fresh pip install -r requirements.txt call. Either updating directly on the device (if internet access is enabled on-device) or by rebuilding the SD card through the usual steps.

Further considerations:

  • In initial tests with simple PSBTs, signing a PSBT is now nearly instantaneous. If signing more complex PSBTs are reasonably fast, it may make sense to remove the loading/waiting spinner on that page.
  • Similarly, brute-force address verification is so fast that "Skip 10" now seems pointlessly small. Perhaps a "Skip 50" or "Skip 100"?

@SeedSigner
Copy link
Owner

Great work on this Keith, thank you.

@SeedSigner SeedSigner merged commit 97c7eaf into SeedSigner:dev Jun 12, 2022
@newtonick newtonick added this to the 0.5.1 milestone Jun 16, 2022
@newtonick newtonick mentioned this pull request Jun 16, 2022
@kdmukai kdmukai deleted the secp256k1_binary branch September 2, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants