[Bugfix] Manually entering seed phrase after psbt scan or addr verification scan fails; orphaned loading screen spinner fix #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes SeedSigner#188 * Only runs the spinner when the psbt actually needs to be reparsed (returning to the PSBT Overview screen via BACK button doesn't need to reparse the psbt so the spinner is no longer displayed).
kdmukai
changed the title
kdmukai
changed the title
|
LGTM Reviewed code change and tested on local device without any issues |
1 similar comment
|
LGTM Reviewed code change and tested on local device without any issues |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG:
Result: Exception at line 68 in
seed_storage.pybecause the_pending_mnemonicwas not yet initialized.Fix: Provide the same 12- or 24-word seed option from "Load Seed" so that we know how long the mnemonic will be and can properly initialize
_pending_mnemonic.Also standardizes the UI on listing the 12-word option first. Matches the order used in the Tools screens when creating new seeds.
Additional commit (accidentally committed this separate change into this same branch):
Improved handling for the
PSBTOverviewViewloading screen spinnerFixes #188
Also ensures the spinner exits on crashes on:
PSBTFinalizeViewSeedExportXpubDetailsView