-
Notifications
You must be signed in to change notification settings - Fork 255
Updated "Final Word" calculation flow #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
pytest failed |
|
Feature works perfectly for me during testing on local device. I also verified against https://bitcoiner.guide/seed/ and got the same 12/24 words. |
|
Does the pytest failure mean that the test needs to be revised to accommodate this feature's new changes, or that changes may beed to be made to the feature's code so the test completes properly? |
|
Merged latest changes from |
|
LGTM Reviewed code and tested without any issues |
Updated "Final Word" calculation flow
Requires #196 to be merged first.
Should be targeted for v0.5.1 or greater.
Props to @brandonblack for doing the initial work to get this feature started.