Skip to content

fix(shim): Run JAR file directly, close #6203 #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cesaryuan wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

fix(shim): Run JAR file directly, close #6203 #6205

cesaryuan wants to merge 4 commits into from

Conversation

@cesaryuan
Copy link

@cesaryuan cesaryuan commented Oct 26, 2024

Description

Run JAR file directly instead of running it in app's directory.

Motivation and Context

Closes #6203

How Has This Been Tested?

scoop install main/bfg
# run bfg in some git repo, it works now

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@cesaryuan
Copy link
Author

cesaryuan commented Aug 11, 2025

Is there any work that needs to be done?

@HUMORCE
Copy link
Member

HUMORCE commented Aug 11, 2025

Please check #6030 and git blame

The related changes of JAVA App shim are always targeted at specific apps; perhaps we need another way to solve this issue, such as providing option to set working directory?

@Shivelight
Copy link

Shivelight commented Aug 30, 2025

The related changes of JAVA App shim are always targeted at specific apps; perhaps we need another way to solve this issue, such as providing option to set working directory?

Could this be an option in the manifest? Some apps prefer running from their root directory while others, like apktool, prefer the current working directory #6026 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cesaryuan @HUMORCE @Shivelight