Skip to content

fix(scoop-install): Prevent installation of Scoop itself #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
HUMORCE wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(scoop-install): Prevent installation of Scoop itself #6158

HUMORCE wants to merge 2 commits into from

Conversation

@HUMORCE
Copy link
Member

@HUMORCE HUMORCE commented Sep 28, 2024

Description

Motivation and Context

Closes #5739

How Has This Been Tested?

❯ scoop install scoop
ERROR: You cannot install Scoop via 'scoop install'

❯ scoop install main/scoop
ERROR: You cannot install Scoop via 'scoop install'

❯ scoop install /scoop
ERROR: You cannot install Scoop via 'scoop install'

❯ scoop install openssl scoop scoop scoop x
ERROR: You cannot install Scoop via 'scoop install'

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@HUMORCE
Copy link
Member Author

HUMORCE commented Sep 30, 2024

Alternatively, remove Scoop from the $apps array when installing multiple apps.

@HUMORCE HUMORCE mentioned this pull request Dec 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@HUMORCE