Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tesseract: Fix hash, add post-install and fix hash in tesseract-languages #54

Merged
merged 2 commits into from
May 20, 2019
Merged

tesseract: Fix hash, add post-install and fix hash in tesseract-languages #54

merged 2 commits into from
May 20, 2019

Conversation

niheaven
Copy link
Member

@niheaven niheaven commented May 13, 2019 •
edited
Loading

Close #43, close #59, close #76

@niheaven niheaven changed the title tesseract: Add post-install and fix hash in tesseract-languages tesseract: Fix hash, add post-install and fix hash in tesseract-languages May 19, 2019
@niheaven niheaven requested review from Ash258 and r15ch13 May 20, 2019 09:01
Ash258
Ash258 approved these changes May 20, 2019
View reviewed changes
Copy link
Contributor

@Ash258 Ash258 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not use tesseract, so cannot tell if env is neeeded, but manifest looks good.

@niheaven
Copy link
Member Author

That's fine, tesseract-languages set TESSDATA_PREFIX to its own dir, while tesseract set to its tessdata subdir. If tesseract-languages is installed, one should reset tesseract-languagesafter updatingtesseract, so let's tesseract's post_install` do this env reset is better.

@niheaven niheaven merged commit 3b91c2a into ScoopInstaller:master May 20, 2019
@niheaven niheaven deleted the fix-tesseract branch May 20, 2019 09:09
@niheaven niheaven removed the request for review from r15ch13 May 20, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ash258 Ash258 Ash258 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[email protected]: hash check failed [email protected]: hash check failed [email protected]: hash check failed
2 participants
@niheaven @Ash258