[email protected]: More reliable checkver logic #14389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
All changes look good. Wait for review from human collaborators. xnconvert
|
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. xnconvert
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XnConvert manifest https://github.com/ScoopInstaller/Extras/blob/master/bucket/xnconvert.json currently uses the product homepage https://www.xnview.com/en/xnconvert/ to get latest version. But the homepage is not always updated at the same time a new version of XnConvert is released.
I learned from Dumplings ( https://github.com/SpecterShell/Dumplings/blob/main/Tasks/XnSoft.XnConvert/Script.ps1 ) that XnConvert also has a download directory with versions: https://download.xnview.com/old_versions/XnConvert/.
I changed the Scoop checkver logic to use this URL to get latest version of XnConvert instead.