Fix typo and add QA item #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Salvoxia Thanks for reviewing PR |
Salvoxia
requested changes
Oct 28, 2024
README.md
Outdated
| -u udp://VPN.SERVERNAME.COM:PORT \ # Your public IP/domain and port forwarded to Docker | ||
| -t \ # Enable TAP mode | ||
| -B \ # Enable bridging mode | ||
| --bridge-name 'br0' \ # Bridge interface name (Optional, change if br0 already exists) |
There was a problem hiding this comment.
The parameter --bridge-name itself is actually not optional, but changing br0 to another name might be. br0 is a good default value unless another bridge already exists.
There was a problem hiding this comment.
THANKS, that is my misunderstanding
Salvoxia
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.